hw06_pipeline_execution #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofiiakulish
force-pushed
the
hw06_pipeline_execution
branch
from
51a5179 to
9598626
Compare
sshaplygin
approved these changes
Aug 17, 2022
Collaborator
sshaplygin
left a comment
sshaplygin
left a comment
There was a problem hiding this comment.
Здравствуйте. Спасибо за выполненное задание. Хорошая работа. Жаль, что вы не добавили дополнительные тесты на вашу работу.
- Добавлены новые юнит-тесты - до 0/2 баллов
Итого: 8/10
Нотация:
👍 - Классное, не обычное, оригинальное решение
👀 - Стоит обратить внимание. Рекомендация, которая не влияет на успешность выполнения задания
🔥 - Критичное замечание, которое влияет на сдачу задания
| case <-done: | ||
| return | ||
| case v, ok := <-in: | ||
| if ok == false { |
Collaborator
There was a problem hiding this comment.
👀
Можно явно записать
if !ok {
return
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Домашнее задание №6 «Пайплайн»
Чек-лист студента (Что это?)
go mod tidy..syncфайл. Зачем его удалять?Критерии оценки
Зачёт от 7 баллов